Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update array pool config, allow driver to request a max sized array #764

Merged
merged 11 commits into from
Jan 5, 2024
Merged

Update array pool config, allow driver to request a max sized array #764

merged 11 commits into from
Jan 5, 2024

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Jan 3, 2024 •
edited
Loading

This change:

  • Adds unit tests for the pool
  • modifies the array pool to allow for a max array length to be requested, this is in order to ensure against breaking change as the message reader could expand to that size.
  • Replaces some established configuration.

AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Jan 4, 2024
View reviewed changes
Neo4j.Driver/Neo4j.Driver/Config.cs Outdated Show resolved Hide resolved
@thelonelyvulpes thelonelyvulpes merged commit d3a9a4c into 5.0 Jan 5, 2024
5 checks passed
@thelonelyvulpes thelonelyvulpes deleted the pool-config branch January 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardIrons-neo4j RichardIrons-neo4j RichardIrons-neo4j approved these changes

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelonelyvulpes @AndyHeap-NeoTech @RichardIrons-neo4j