Make property mapping fail when record is missing field, unless the property is marked with an attribute #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes for making things optional or giving them a default value
Neo4j.Driver/Neo4j.Driver/Preview/Mapping/MappingFailedException.cs
Outdated
Show resolved
Hide resolved
AndyHeap-NeoTech
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of property mapping so that if a property is in the class but it cannot be populated, an exception is thrown, instead of it silently doing nothing. Two new attributes have been added:
[MappingOptional](properties only)This marks the property as optional. If a value is not found in the record, the mapper does nothing (the old default behaviour).
[MappingDefaultValue(someValue)](properties and constructor parameters)This provides a default value which will be put into the property or constructor if a suitable value is not found in the record.
Tests were added for the new features, as well as the specific issues raised that led to this change.