Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL Status objects for notifications #809

Merged
merged 27 commits into from
Aug 1, 2024

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Jul 22, 2024

This change introduces a preview of GQL-compliant notifications and status objects for the driver.

https://www.gqlstandards.org/

This change also introduces bolt 5.6& 5.5

@thelonelyvulpes thelonelyvulpes marked this pull request as ready for review July 26, 2024 08:40
@thelonelyvulpes thelonelyvulpes changed the title Gql notifications GQL Status objects for notifications Jul 26, 2024
Copy link

@StephenCathcart StephenCathcart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature looks good to me 👍

Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Just a couple of very minor comments that don't really need anything doing if you can't be bothered.

nameof(NotificationSeverity.Warning),
StringComparison.InvariantCultureIgnoreCase);
var status = isWarning
? "01N42"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reference or link to doc where value is specified. GQL spec or something perhaps?

@thelonelyvulpes thelonelyvulpes merged commit 8fdfeed into neo4j:5.0 Aug 1, 2024
4 of 5 checks passed
@thelonelyvulpes thelonelyvulpes deleted the gql-notifications branch August 1, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants