-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GQL Status objects for notifications #809
Conversation
…e breaking behavior on serialization of notification category.
Neo4j.Driver/Neo4j.Driver.Tests.TestBackend/Protocol/Result/SummaryJsonSerializer.cs
Outdated
Show resolved
Hide resolved
Neo4j.Driver/Neo4j.Driver/Internal/Protocol/BoltProtocolMessageFactory.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Just a couple of very minor comments that don't really need anything doing if you can't be bothered.
Neo4j.Driver/Neo4j.Driver/Internal/MessageHandling/Metadata/GqlStatusObjectsAndNotifications.cs
Show resolved
Hide resolved
nameof(NotificationSeverity.Warning), | ||
StringComparison.InvariantCultureIgnoreCase); | ||
var status = isWarning | ||
? "01N42" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe reference or link to doc where value is specified. GQL spec or something perhaps?
This change introduces a preview of GQL-compliant notifications and status objects for the driver.
https://www.gqlstandards.org/
This change also introduces bolt 5.6& 5.5