Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package references #829

Open
wants to merge 1 commit into
base: 5.0
Choose a base branch
from

Conversation

gpetrou
Copy link
Collaborator

@gpetrou gpetrou commented Dec 13, 2024

net5.0 does not seem to be used.
Microsoft.Bcl.AsyncInterfaces 5.0.0 gives a warning as per #817.
System.ValueTuple is already included.
Microsoft.Bcl.AsyncInterfaces is only needed for netstandard2.0.

@gpetrou
Copy link
Collaborator Author

gpetrou commented Dec 14, 2024

@RichardIrons-neo4j how can I see the Teamcity build logs?

@RichardIrons-neo4j
Copy link
Contributor

Hi @gpetrou, and thank you for contributing to the code base!

The build is failing because to be able to merge your changes we will need a signed CLA from you. TeamCity checks a whitelist of users that have signed and fails the build if the PR comes from a user not on the list.

See http://neo4j.com/developer/cla/ for further information.

Additional information on contributing code can be found at
http://neo4j.com/developer/contributing-code/

@RichardIrons-neo4j
Copy link
Contributor

Hi @gpetrou, and thank you for contributing to the code base!

The build is failing because to be able to merge your changes we will need a signed CLA from you. TeamCity checks a whitelist of users that have signed and fails the build if the PR comes from a user not on the list.

See http://neo4j.com/developer/cla/ for further information.

Additional information on contributing code can be found at http://neo4j.com/developer/contributing-code/

Never mind, I've just foundf your CLA. I'll get on with adding you to the whitelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants