Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate IT tests to Testkit #1096

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Commits on Dec 3, 2021

  1. Migrate IT tests to Testkit

    Tests:
    - `CausalClusteringIT.beginTransactionThrowsForInvalidBookmark` -> `TestBookmarks.test_fails_on_invalid_bookmark`, a similar case is also covered by `Routing.test_should_fail_with_routing_failure_on_invalid_bookmark_discovery_failure`
    - `CausalClusteringIT.shouldAcceptMultipleBookmarks` -> `TestBookmarks.test_can_handle_multiple_bookmarks`
    - `CausalClusteringIT.bookmarksShouldWorkWithDriverPinnedToSingleServer` -> `TestBookmarks.test_can_pass_write_bookmark_into_write_session` (Similar test, the original had dependency on constant leader. The suggested test seems to closely match expectation of bookmark behaviour on a single node.)
    - `CausalClusteringIT.shouldUseBookmarkFromAReadSessionInAWriteSession` -> `TestBookmarks.test_can_pass_read_bookmark_into_write_session` (Similar test, the original had dependency on constant leader. The suggested test seems to closely match expectation of bookmark behaviour on a single node.)
    - `CausalClusteringIT.sessionCreationShouldFailIfCallingDiscoveryProcedureOnEdgeServer` -> `Routing.test_should_fail_discovery_when_router_fails_with_procedure_not_found_code` (Similar test, the original was actually skipped because builds run with 4.x series.)
    injectives committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6242f0e View commit details
    Browse the repository at this point in the history