Migrate Java IT tests to Testkit #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated tests: - `CausalClusteringIT.shouldNotReuseReadConnectionForWriteTransaction` -> `TestBookmarks.test_does_not_use_read_connection_for_write` - `CausalClusteringIT.shouldExecuteReadAndWritesWhenDriverSuppliedWithAddressOfLeader` -> `Routing.test_should_get_rt_from_leader_w_and_r_via_leader_using_session_run` - `CausalClusteringIT.shouldExecuteReadAndWritesWhenDriverSuppliedWithAddressOfFollower` -> `Routing.test_should_get_rt_from_follower_w_and_r_via_leader_using_session_run` - `CausalClusteringIT.shouldDropBrokenOldConnections` -> `Routing.test_should_drop_connections_failing_liveness_check` - `CausalClusteringIT.shouldRespectMaxConnectionPoolSizePerClusterMember` -> `Routing.test_should_enforce_pool_size_per_cluster_member` - `CausalClusteringIT.shouldKeepOperatingWhenConnectionsBreak` -> unexpected interruptions are covered by routing tests `Routing.test_should_retry_read_tx_until_success_on_run_error`, `Routing.test_should_retry_read_tx_until_success_on_pull_error`, `Routing.test_should_retry_read_tx_until_success_on_error`, `Routing.test_should_retry_read_tx_and_rediscovery_until_success_on_run_failure`, `Routing.test_should_retry_read_tx_and_rediscovery_until_success_on_pull_failure`, `Routing.test_should_retry_read_tx_and_rediscovery_until_success`, `Routing.test_should_retry_write_tx_and_rediscovery_until_success_on_run_failure`, `Routing.test_should_retry_write_until_success_with_leader_change_on_run_using_tx_function`, `Routing.test_should_retry_write_tx_until_success_on_run_error`, `Routing.test_should_retry_write_tx_until_success_on_pull_error`, `Routing.test_should_retry_write_tx_and_rediscovery_until_success_on_pull_failure`, `Routing.test_should_retry_write_until_success_with_leader_change_using_tx_function`, `Routing.test_should_retry_write_tx_until_success_on_error`, `Routing.test_should_retry_write_tx_and_rediscovery_until_success` Converted tests: - `CausalClusteringIT.shouldExecuteReadAndWritesWhenRouterIsDiscovered` -> `GraphDatabaseTest.shouldNotFailRoutingDriverWhenThereIsWorkingUri` New Testkit features: - `Feature:API:Liveness.Check` - `Temporary:DriverMaxConnectionPoolSize` - `Temporary:ConnectionAcquisitionTimeout` - `Temporary:GetConnectionPoolMetrics` The `address` field has been added to `Summary` Testkit response.
injectives
force-pushed
the
feature/testmig
branch
from
1fdfe68 to
6a15673
Compare
gjmwoods
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated tests:
CausalClusteringIT.shouldNotReuseReadConnectionForWriteTransaction->TestBookmarks.test_does_not_use_read_connection_for_writeCausalClusteringIT.shouldExecuteReadAndWritesWhenDriverSuppliedWithAddressOfLeader->Routing.test_should_get_rt_from_leader_w_and_r_via_leader_using_session_runCausalClusteringIT.shouldExecuteReadAndWritesWhenDriverSuppliedWithAddressOfFollower->Routing.test_should_get_rt_from_follower_w_and_r_via_leader_using_session_runCausalClusteringIT.shouldDropBrokenOldConnections->Routing.test_should_drop_connections_failing_liveness_checkCausalClusteringIT.shouldRespectMaxConnectionPoolSizePerClusterMember->Routing.test_should_enforce_pool_size_per_cluster_memberCausalClusteringIT.shouldKeepOperatingWhenConnectionsBreak-> unexpected interruptions are covered by routing testsRouting.test_should_retry_read_tx_until_success_on_run_error,Routing.test_should_retry_read_tx_until_success_on_pull_error,Routing.test_should_retry_read_tx_until_success_on_error,Routing.test_should_retry_read_tx_and_rediscovery_until_success_on_run_failure,Routing.test_should_retry_read_tx_and_rediscovery_until_success_on_pull_failure,Routing.test_should_retry_read_tx_and_rediscovery_until_success,Routing.test_should_retry_write_tx_and_rediscovery_until_success_on_run_failure,Routing.test_should_retry_write_until_success_with_leader_change_on_run_using_tx_function,Routing.test_should_retry_write_tx_until_success_on_run_error,Routing.test_should_retry_write_tx_until_success_on_pull_error,Routing.test_should_retry_write_tx_and_rediscovery_until_success_on_pull_failure,Routing.test_should_retry_write_until_success_with_leader_change_using_tx_function,Routing.test_should_retry_write_tx_until_success_on_error,Routing.test_should_retry_write_tx_and_rediscovery_until_successConverted tests:
CausalClusteringIT.shouldExecuteReadAndWritesWhenRouterIsDiscovered->GraphDatabaseTest.shouldNotFailRoutingDriverWhenThereIsWorkingUriNew Testkit features:
Feature:API:Liveness.CheckTemporary:DriverMaxConnectionPoolSizeTemporary:ConnectionAcquisitionTimeoutTemporary:GetConnectionPoolMetricsThe
addressfield has been added toSummaryTestkit response.