Skip to content

Fix missing exception conversion in TestKit backend #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Fix missing exception conversion in TestKit backend #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...end/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionReadTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import lombok.Getter;
import lombok.Setter;
import neo4j.org.testkit.backend.FrontendError;
import neo4j.org.testkit.backend.TestkitState;
import neo4j.org.testkit.backend.holder.AsyncTransactionHolder;
import neo4j.org.testkit.backend.holder.RxTransactionHolder;
Expand Down Expand Up @@ -123,10 +124,11 @@ private TransactionWork<Void> handle( TestkitState testkitState, SessionHolder s
{
throw (Neo4jException) workThrowable;
}
else
if ( workThrowable instanceof FrontendError )
{
throw new RuntimeException( "Unexpected exception occurred in transaction work function", workThrowable );
throw (FrontendError) workThrowable;
}
throw new RuntimeException( "Unexpected exception occurred in transaction work function", workThrowable );
}
};
}
Expand Down
6 changes: 4 additions & 2 deletions ...nd/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionWriteTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import lombok.Getter;
import lombok.Setter;
import neo4j.org.testkit.backend.FrontendError;
import neo4j.org.testkit.backend.TestkitState;
import neo4j.org.testkit.backend.holder.AsyncTransactionHolder;
import neo4j.org.testkit.backend.holder.RxTransactionHolder;
Expand Down Expand Up @@ -126,10 +127,11 @@ private TransactionWork<Void> handle( TestkitState testkitState, SessionHolder s
{
throw (Neo4jException) workThrowable;
}
else
if ( workThrowable instanceof FrontendError )
{
throw new RuntimeException( "Unexpected exception occurred in transaction work function", workThrowable );
throw (FrontendError) workThrowable;
}
throw new RuntimeException( "Unexpected exception occurred in transaction work function", workThrowable );
}
};
}
Expand Down