Introduce new managed transaction methods and deprecate existing ones #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/txf
branch
6 times, most recently
from
dd182f9
to
61b4371
Compare
injectives
changed the title
injectives
changed the title
injectives
force-pushed
the
feature/txf
branch
5 times, most recently
from
670d8fa
to
d22493c
Compare
This update introduces new methods for managed transactions, also known as transaction functions. Furthermore, it deprecates the existing methods. The new methods are: - `executeRead` (synchronous and reactive), `executeReadAsync` (asynchronous) - `executeWrite` (synchronous and reactive), `executeWriteAsync` (asynchronous) - `executeWriteWithoutResult` (synchronous) There are overloaded options that take transaction configuration. The new methods do not permit explicit management (commit, rollback, close) of managed transaction. The driver will attempt committing the transaction as long as the provided unit of work completes successfully.
gjmwoods
approved these changes
Apr 1, 2022
michael-simons
requested changes
Apr 1, 2022
There was a problem hiding this comment.
This is a great change to the surface of the driver, thank you for that!
I went in detail through all the JavaDoc. I appreciate the information about the semantics, it should go in a doc, too.
I annotated the blocking session with a couple of suggestions. Please apply them to the standard session and do the same for async and reactive.
Thank you.
michael-simons
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces new methods for managed transactions, also known as transaction functions. Furthermore, it deprecates the existing methods.
The new methods are:
executeRead(synchronous and reactive),executeReadAsync(asynchronous)executeWrite(synchronous and reactive),executeWriteAsync(asynchronous)executeWriteWithoutResult(synchronous)There are overloaded options that take transaction configuration.
The new methods do not permit explicit management (commit, rollback, close) of managed transaction. The driver will attempt committing the transaction as long as the provided unit of work completes successfully.