Introduce new reactive session with updated API #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
approved these changes
Apr 12, 2022
injectives
force-pushed
the
feature/reative-api
branch
4 times, most recently
from
0c9fe2a
to
da6fdeb
Compare
This update introduces a new reactive session called `ReactiveSession` and deprecates the existing `RxSession`. The new session can be created via `reactiveSession` methods on `Driver`. The `ReactiveSession` brings reactive API in line with synchronous and asynchronous when it comes to getting an instance on result handle (`ReactiveResult`). Specifically, `run` methods return a `Publisher<ReactiveResult>` that will only emit `ReactiveResult` instance on successful Bolt message (`RUN`) exchange and will emit an error on failure. Furthermore, this change allowed simplification of `ReactiveResult.keys()` method that simply returns a list of strings now. This update also adds a new reactive backend implementation for Testkit and renames existing implementation to `reactive-legacy`.
injectives
force-pushed
the
feature/reative-api
branch
from
da6fdeb
to
51b2666
Compare
gjmwoods
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a new reactive session called
ReactiveSessionand deprecates the existingRxSession.The new session can be created via
reactiveSessionmethods onDriver.The
ReactiveSessionbrings reactive API in line with synchronous and asynchronous when it comes to getting an instance on result handle (ReactiveResult). Specifically,runmethods return aPublisher<ReactiveResult>that will only emitReactiveResultinstance on successful Bolt message (RUN) exchange and will emit an error on failure. Furthermore, this change allowed simplification ofReactiveResult.keys()method that simply returns a list of strings now.This update also adds a new reactive backend implementation for Testkit and renames existing implementation to
reactive-legacy.