Update bookmarks API #1211
Merged
Update bookmarks API #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/bookmarks
branch
3 times, most recently
from
cd48d0b to
8cf2572
Compare
injectives
force-pushed
the
feature/bookmarks
branch
2 times, most recently
from
09b7beb to
090a891
Compare
`Bookmark` objects should represent singular bookmark values. Multiple bookmarks will be represented as a set of bookmarks (`Set<Bookmark>`). The main API updates are highlighted below. `Bookmark` updates: - `value()` - new method - `values()` - deprecated - `isEmpty()` - deprecated `Session` and `AsyncSession` updates: - `Set<Bookmark> lastBookmarks()` - new method - `Bookmark lastBookmark()` - deprecated `ReactiveSession` updates: - `Set<Bookmark> lastBookmarks()` - new method - `Bookmark lastBookmark()` - deprecated (has not been released)
injectives
force-pushed
the
feature/bookmarks
branch
from
090a891 to
4202244
Compare
michael-simons
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmarkobjects should represent singular bookmark values. Multiple bookmarks will be represented as a set of bookmarks (Set<Bookmark>).The main API updates are highlighted below.
Bookmarkupdates:value()- new methodvalues()- deprecatedisEmpty()- deprecatedSessionandAsyncSessionupdates:Set<Bookmark> lastBookmarks()- new methodBookmark lastBookmark()- deprecatedReactiveSessionupdates:Set<Bookmark> lastBookmarks()- new methodBookmark lastBookmark()- deprecated (has not been released)