Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ITs to Testkit #1214

Merged
merged 1 commit into from
May 9, 2022
Merged

Migrate ITs to Testkit #1214

merged 1 commit into from
May 9, 2022

Conversation

injectives
Copy link
Contributor

Migrated tests:

  • NestedQueriesIT.shouldAllowNestedQueriesInTransactionConsumedAsIterators -> TestIterationTxRun.test_nested
  • NestedQueriesIT.shouldAllowNestedQueriesInTransactionConsumedAsIteratorAndList -> TestIterationTxRun.test_nested_using_list
  • NestedQueriesIT.shouldAllowNestedQueriesInSessionConsumedAsIterators -> TestIterationSessionRun.test_nested
  • NestedQueriesIT.shouldAllowNestedQueriesInSessionConsumedAsIteratorAndList -> TestIterationSessionRun.test_nested_using_list

Deleted tests:

  • shouldAllowNestedQueriesInTransactionConsumedAsLists -> deleted, it is effectively a sequential query execution
  • shouldAllowNestedQueriesInSessionConsumedAsLists -> deleted, it is effectively a sequential query execution
  • CausalClusteringIT -> deleted, unsafe cluster tests

Migrated tests:
- `NestedQueriesIT.shouldAllowNestedQueriesInTransactionConsumedAsIterators` -> `TestIterationTxRun.test_nested`
- `NestedQueriesIT.shouldAllowNestedQueriesInTransactionConsumedAsIteratorAndList` -> `TestIterationTxRun.test_nested_using_list`
- `NestedQueriesIT.shouldAllowNestedQueriesInSessionConsumedAsIterators` -> `TestIterationSessionRun.test_nested`
- `NestedQueriesIT.shouldAllowNestedQueriesInSessionConsumedAsIteratorAndList` -> `TestIterationSessionRun.test_nested_using_list`

Deleted tests:
- `shouldAllowNestedQueriesInTransactionConsumedAsLists` -> deleted, it is effectively a sequential query execution
- `shouldAllowNestedQueriesInSessionConsumedAsLists` -> deleted, it is effectively a sequential query execution
- `CausalClusteringIT` -> deleted, unsafe cluster tests
@injectives injectives requested a review from gjmwoods May 6, 2022 20:17
@injectives injectives merged commit 59600be into neo4j:5.0 May 9, 2022
@injectives injectives deleted the feature/tests branch May 9, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants