Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap checked exceptions when rethrowing async exception #1245

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

injectives
Copy link
Contributor

Driver may throw checked exception without declaring it. This update fixes this behaviour.

@injectives injectives marked this pull request as draft June 12, 2022 18:56
@injectives injectives force-pushed the feature/exceptions branch 3 times, most recently from c7f63bd to 7fe0ad3 Compare June 12, 2022 21:17
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. I'm glad you didn't forget about this.

@injectives injectives marked this pull request as ready for review June 14, 2022 10:07
Driver may throw checked exception without declaring it. This update fixes this behaviour.
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks.

@injectives injectives merged commit 1a286f1 into neo4j:5.0 Jun 22, 2022
@injectives injectives deleted the feature/exceptions branch June 22, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants