Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending datetime values in UTC #1247

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

injectives
Copy link
Contributor

This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.

@injectives injectives marked this pull request as draft June 15, 2022 12:07
@injectives injectives force-pushed the feature/datetime branch 10 times, most recently from 504e874 to 0ab170a Compare June 16, 2022 11:39
@injectives injectives marked this pull request as ready for review June 16, 2022 11:43
@injectives injectives force-pushed the feature/datetime branch 2 times, most recently from ecca763 to b5dfb20 Compare June 16, 2022 13:16
This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essential fix, all good and inline with ADR-05.

Let's take a mental note that we might thinking about a more dedicated Patch structure than single arguments in case we need more patches in the future to come.

@injectives injectives merged commit e056f71 into neo4j:5.0 Jun 21, 2022
@injectives injectives deleted the feature/datetime branch June 21, 2022 22:15
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Jun 23, 2022
* Add support for sending datetime values in UTC

This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.

* Add type feature

* Skip tests needing additional type support

* Update tests name

* Update matching

* Update matching
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Jun 23, 2022
* Add support for sending datetime values in UTC

This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.

* Add type feature

* Skip tests needing additional type support

* Update tests name

* Update matching

* Update matching
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Jun 23, 2022
* Add support for sending datetime values in UTC

This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.

* Add type feature

* Skip tests needing additional type support

* Update tests name

* Update matching

* Update matching
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Jun 23, 2022
* Add support for sending datetime values in UTC

This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.

* Add type feature

* Skip tests needing additional type support

* Update tests name

* Update matching

* Update matching
injectives added a commit that referenced this pull request Jun 23, 2022
* Add support for sending datetime values in UTC

This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.

Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.

* Add type feature

* Skip tests needing additional type support

* Update tests name

* Update matching

* Update matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants