-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sending datetime values in UTC #1247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/datetime
branch
10 times, most recently
from
June 16, 2022 11:39
504e874
to
0ab170a
Compare
injectives
force-pushed
the
feature/datetime
branch
2 times, most recently
from
June 16, 2022 13:16
ecca763
to
b5dfb20
Compare
This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69. Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.
injectives
force-pushed
the
feature/datetime
branch
from
June 16, 2022 13:34
b5dfb20
to
c51eba7
Compare
7 tasks
michael-simons
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essential fix, all good and inline with ADR-05.
Let's take a mental note that we might thinking about a more dedicated Patch
structure than single arguments in case we need more patches in the future to come.
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jun 23, 2022
* Add support for sending datetime values in UTC This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69. Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged. * Add type feature * Skip tests needing additional type support * Update tests name * Update matching * Update matching
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jun 23, 2022
* Add support for sending datetime values in UTC This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69. Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged. * Add type feature * Skip tests needing additional type support * Update tests name * Update matching * Update matching
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jun 23, 2022
* Add support for sending datetime values in UTC This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69. Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged. * Add type feature * Skip tests needing additional type support * Update tests name * Update matching * Update matching
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jun 23, 2022
* Add support for sending datetime values in UTC This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69. Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged. * Add type feature * Skip tests needing additional type support * Update tests name * Update matching * Update matching
injectives
added a commit
that referenced
this pull request
Jun 23, 2022
* Add support for sending datetime values in UTC This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69. Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged. * Add type feature * Skip tests needing additional type support * Update tests name * Update matching * Update matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update brings 2 new Bolt structures for transmitting datetime in UTC, specifically tag bytes 49 and 69.
Bolt 5 will only support these structures and will no longer accept tag bytes 46 and 66. Bolt 4.4 and 4.3 will negotiate with server and use the new structures if possible. Previous protocol versions behaviour remains unchanged.