TestKit backend: add full support for temporal types #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
testkit-backend-serialize-temporal-types
branch
5 times, most recently
from
63fd21c to
ae7fdcd
Compare
robsdedude
force-pushed
the
testkit-backend-serialize-temporal-types
branch
from
ae7fdcd to
2ea05ca
Compare
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartSubTest.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartSubTest.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartSubTest.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
...n/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitCypherTypeMapper.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
...main/java/neo4j/org/testkit/backend/messages/requests/deserializer/types/CypherDateTime.java
Outdated
Show resolved
Hide resolved
Co-authored-by: injectives <11927660+injectives@users.noreply.github.com>
Signed-off-by: Rouven Bauer <rouven.bauer@neo4j.com>
robsdedude
commented
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitriy Tverdiakov <dmitriy.tverdiakov@neo4j.com>
injectives
reviewed
Jul 5, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartSubTest.java
Outdated
Show resolved
Hide resolved
injectives
reviewed
Jul 5, 2022
...main/java/neo4j/org/testkit/backend/channel/handler/TestkitRequestResponseMapperHandler.java
Outdated
Show resolved
Hide resolved
injectives
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be backported to 4.4 (without the SubTest message support, that's TestKit 5.0+)