Add Java module declaration for neo4j-java-driver

[injectives]

This update introduces an explicit org.neo4j.driver Java module declaration for neo4j-java-driver artifact. The introduced module name matches the previously used Automatic-Module-Name value.

org.neo4j.driver.internal.RevocationStrategy has been moved to org.neo4j.driver.RevocationStrategy.

[michael-simons]

Hey @alina-yur quick question here that we ran into.
We are adding proper Java Module System to our driver and we are using org.graalvm.nativeimage:svm in provided scope for adding a bunch of substitutions, making active use of those:

neo4j-java-driver/driver/src/main/java/org/neo4j/driver/internal/svm/NettySubstitutions.java

Lines 21 to 23 in 71aee3f

	import com.oracle.svm.core.annotate.Alias;
	import com.oracle.svm.core.annotate.Substitute;
	import com.oracle.svm.core.annotate.TargetClass;

Now, for this to work on the module path, we require the corresponding module statically:

https://github.com/neo4j/neo4j-java-driver/pull/1274/files#diff-9d9468f1a44673612059e5cc10b501e82d34253cf56f16ae1925962ea60035afR39

module org.neo4j.driver {
    // The rest omitted
    requires static org.graalvm.nativeimage.builder;
}

Asorg.graalvm.nativeimage.builder does not export above annotations but only to a selected set of modules stuff needs help on compilation:

 <compilerArgs>
     <arg>--add-exports</arg>
     <arg>jdk.internal.vm.ci/jdk.vm.ci.code=org.graalvm.nativeimage.builder</arg>
     <arg>--add-exports</arg>
     <arg>org.graalvm.nativeimage.builder/com.oracle.svm.core.annotate=org.neo4j.driver</arg>
     <arg>--add-exports</arg>
     <arg>org.graalvm.nativeimage.builder/com.oracle.svm.core.jdk=org.neo4j.driver</arg>
</compilerArgs>

but we want to avoid those.

From your module info:

    exports com.oracle.svm.core.annotate to
        com.oracle.svm.svm_enterprise,
        jdk.internal.vm.compiler,
        org.graalvm.nativeimage.agent.diagnostics,
        org.graalvm.nativeimage.agent.jvmtibase,
        org.graalvm.nativeimage.agent.tracing,
        org.graalvm.nativeimage.base,
        org.graalvm.nativeimage.configure,
        org.graalvm.nativeimage.driver,
        org.graalvm.nativeimage.junitsupport,
        org.graalvm.nativeimage.librarysupport,
        org.graalvm.nativeimage.llvm;

and we are wondering if our usages is
a) correct at all
b) what happens on the module path
c) is that just an oversight on your side

It would be most awesome if you or someone else could point us to the correct manual or give a hint how to procceed.

[michael-simons]

Hmm @christianwimmer could you point me please to the correct path forward with these substitutions given the changes / advances in the native image API if you have a moment somewhen. Thanks !

[olpaw]

Hi @michael-simons

you will want to use

module org.neo4j.driver {
    ...
    requires org.graalvm.sdk;
    ...
}

then you have access to all our public API:
https://www.graalvm.org/sdk/javadoc/

Let me know if you need more help!