Introduce BookmarkManager #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/bookmarkmanager
branch
15 times, most recently
from
96c9f27
to
bfb1a37
Compare
injectives
force-pushed
the
feature/bookmarkmanager
branch
13 times, most recently
from
32c12cd
to
6526902
Compare
injectives
force-pushed
the
feature/bookmarkmanager
branch
2 times, most recently
from
249adb7
to
816ab27
Compare
Bookmark manager is a new opt-in feature that is enabled via driver `Config`. It is responsible for providing an up-to-date set of bookmarks to driver on session creation and database data access. Driver provides a default implementation via `BookmarkManagers.defaultManager`. The default implementation keeps track of a single local driver instance bookmarks only. However, it supports 2 extension points: - `updateListener` - a listener for new bookmarks - `bookmarkSupplier` - a supplier of additional bookmarks It is possible to turn off bookmark manager on session level using `SessionConfig` even when it is enabled on the driver level. Please note that this feature might have an impact on setups that do not manage the driver directly since there is a chance of getting a driver with bookmarks manager enabled. Javadoc includes more general details.
injectives
force-pushed
the
feature/bookmarkmanager
branch
from
816ab27
to
2045d6c
Compare
bigmontz
reviewed
Aug 16, 2022
testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/NewDriver.java
Show resolved
Hide resolved
bigmontz
approved these changes
Aug 16, 2022
Thanks you. Sure, it will be updated separately. |
|
Further surface update: #1290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmark manager is a new opt-in feature that is enabled via driver
Config.It is responsible for providing an up-to-date set of bookmarks to driver on session creation and database data access.
Driver provides a default implementation via
BookmarkManagers.defaultManager. The default implementation keeps track of a single local driver instance bookmarks only. However, it supports 2 extension points:-
updateListener- a listener for new bookmarks-
bookmarkSupplier- a supplier of additional bookmarksIt is possible to turn off bookmark manager on session level using
SessionConfigeven when it is enabled on the driver level.Please note that this feature might have an impact on setups that do not manage the driver directly since there is a chance of getting a driver with bookmarks manager enabled.
Javadoc includes more general details.