Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off hostname verification for trustAllCertificates TrustStrategy #1301

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

injectives
Copy link
Contributor

Config.TrustStrategy.trustAllCertificates() should return TrustStrategy with hostname verification turned off by default.

This update is part of behaviour unification among the official drivers.

`Config.TrustStrategy.trustAllCertificates()` should return `TrustStrategy` with hostname verification turned off by default.

This update is part of behaviour unification among the official drivers.
Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Should the security teams advice change the behaviour can easily be re-enabled.

@injectives injectives merged commit 8c54468 into neo4j:5.0 Sep 1, 2022
@injectives injectives deleted the feature/ssl branch September 1, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants