Update Bookmark Manager for no longer tracking per database #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BookmarkManager interface changes: * The methods `getBookmarks` and `getAllBookmarks` were merge into `getBookmarks`. * `forget` was removed. * The database param was removed from the `updateBookmarks` method. BookmarkManagerConfig changes: * The BookmarksSupplier interface was replaced by Supplier<Set<Bookmark>>. * The bookmarksConsumer changed its type to Consumer<Set<Bookmark>>. * `initialBookmarks` changed its type to Set<Bookmark>
|
Depends on: neo4j-drivers/testkit#534 |
injectives
reviewed
Nov 24, 2022
driver/src/main/java/org/neo4j/driver/internal/async/NetworkSession.java
Outdated
Show resolved
Hide resolved
injectives
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BookmarkManager interface changes:
getBookmarksandgetAllBookmarkswere merge intogetBookmarks.forgetwas removed.updateBookmarksmethod.BookmarkManagerConfig changes:
initialBookmarkschanged its type to Set