Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow supplying a Rediscovery implementation #1350

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Allow supplying a Rediscovery implementation #1350

merged 3 commits into from
Dec 13, 2022

Conversation

injectives
Copy link
Contributor

This is only for internal purposes.

@injectives
Allow supplying a Rediscovery implementation
179d8d8 
This is only for internal purposes.
tobias-johansson
tobias-johansson reviewed Dec 12, 2022
View reviewed changes
Copy link

@tobias-johansson tobias-johansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Does this sort of thing warrant any new tests?

@injectives
Copy link
Contributor Author

Thanks! Definitely. Since this POC has worked for us, I will add more tests soon.

@injectives injectives merged commit 5417654 into neo4j:5.0 Dec 13, 2022
@injectives injectives deleted the feature/rediscovery branch December 13, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-johansson tobias-johansson tobias-johansson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injectives @tobias-johansson