Add new java platform logger #1361
Conversation
|
Nice work! |
|
@Sineaggi, thanks for the contribution. 👍 Would you be happy to sign the CLA please? More info here: https://github.com/neo4j/neo4j-java-driver/blob/1.6/CONTRIBUTING.md#want-to-contribute This is why builds are failing at the moment. |
I have signed the CLA. Please let me know if there are any issues. |
Sineaggi
force-pushed
the
add-java-platform-logger
branch
from
953c879
to
be9e210
Compare
Thanks! The |
| @@ -35,7 +35,7 @@ | |||
| requires io.netty.buffer; | |||
| requires io.netty.codec; | |||
| requires io.netty.resolver; | |||
| requires transitive java.logging; | |||
| requires static java.logging; | |||
There was a problem hiding this comment.
This change triggers compilation failure, caused by the following warning: class java.util.logging.Level in module java.logging is not indirectly exported using requires transitive.
There was a problem hiding this comment.
Wow interesting. I tried creating a reproducer locally but wasn't able to.
According to what I've seen online we can make it static and transitive, but I'm not 100% sure. In this case it's true, the logging class is exporting JUL to downstream users (using the logger in the public return types).
Reading through https://nipafx.dev/java-modules-implied-readability/ right now.
There was a problem hiding this comment.
Is it still failing for the same reasons?
With the java platform logger, we can make the slf4j and jul loggers optional. Users can use implementations of the java platform logging api such as the ones provided by slf4j https://www.slf4j.org/apidocs/org/slf4j/jdk/platform/logging/package-summary.html and log4j https://logging.apache.org/log4j/2.x/log4j-jpl/project-info.html