Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bookmark Manager API GA #1408

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Make Bookmark Manager API GA #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.7-SNAPSHOT</version>
<version>5.8-SNAPSHOT</version>
<relativePath>..</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion driver/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.7-SNAPSHOT</version>
<version>5.8-SNAPSHOT</version>
</parent>

<artifactId>neo4j-java-driver</artifactId>
Expand Down
2 changes: 0 additions & 2 deletions driver/src/main/java/org/neo4j/driver/BookmarkManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import java.io.Serializable;
import java.util.Set;
import org.neo4j.driver.util.Preview;

/**
* Keeps track of bookmarks and is used by the driver to ensure causal consistency between sessions and query executions.
Expand All @@ -31,7 +30,6 @@
*
* @see org.neo4j.driver.SessionConfig.Builder#withBookmarkManager(BookmarkManager)
*/
@Preview(name = "Bookmark Manager")
public interface BookmarkManager extends Serializable {
/**
* Updates bookmarks by deleting the given previous bookmarks and adding the new bookmarks.
Expand Down
2 changes: 0 additions & 2 deletions driver/src/main/java/org/neo4j/driver/BookmarkManagers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@
package org.neo4j.driver;

import org.neo4j.driver.internal.Neo4jBookmarkManager;
import org.neo4j.driver.util.Preview;

/**
* Setups new instances of {@link BookmarkManager}.
*/
@Preview(name = "Bookmark Manager")
public final class BookmarkManagers {
private BookmarkManagers() {}
/**
Expand Down
3 changes: 0 additions & 3 deletions driver/src/main/java/org/neo4j/driver/SessionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import org.neo4j.driver.exceptions.UnsupportedFeatureException;
import org.neo4j.driver.reactive.ReactiveSession;
import org.neo4j.driver.reactive.RxSession;
import org.neo4j.driver.util.Preview;
import org.reactivestreams.Subscription;

/**
Expand Down Expand Up @@ -162,7 +161,6 @@ public Optional<String> impersonatedUser() {
*
* @return bookmark implementation
*/
@Preview(name = "Bookmark Manager")
public Optional<BookmarkManager> bookmarkManager() {
return Optional.ofNullable(bookmarkManager);
}
Expand Down Expand Up @@ -377,7 +375,6 @@ public Builder withImpersonatedUser(String impersonatedUser) {
* @param bookmarkManager bookmark manager implementation. Providing {@code null} effectively disables bookmark manager.
* @return this builder.
*/
@Preview(name = "Bookmark Manager")
public Builder withBookmarkManager(BookmarkManager bookmarkManager) {
this.bookmarkManager = bookmarkManager;
return this;
Expand Down
2 changes: 1 addition & 1 deletion examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.7-SNAPSHOT</version>
<version>5.8-SNAPSHOT</version>
</parent>

<groupId>org.neo4j.doc.driver</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.7-SNAPSHOT</version>
<version>5.8-SNAPSHOT</version>

<packaging>pom</packaging>
<name>Neo4j Java Driver Project</name>
Expand Down
2 changes: 1 addition & 1 deletion testkit-backend/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<artifactId>neo4j-java-driver-parent</artifactId>
<groupId>org.neo4j.driver</groupId>
<version>5.7-SNAPSHOT</version>
<version>5.8-SNAPSHOT</version>
</parent>

<artifactId>testkit-backend</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion testkit-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.7-SNAPSHOT</version>
<version>5.8-SNAPSHOT</version>
<relativePath>..</relativePath>
</parent>

Expand Down