Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mTLS support #1543

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Introduce mTLS support #1543

merged 3 commits into from
Mar 6, 2024

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Mar 4, 2024

Please note that this feature is in preview.

@injectives injectives force-pushed the feature/mtls branch 20 times, most recently from a60f851 to 24d9311 Compare March 5, 2024 12:00
@injectives injectives changed the title Introduce mTLS Introduce mTLS support Mar 5, 2024
@injectives injectives requested a review from bigmontz March 5, 2024 12:05
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the code and I didn't find the place where the hasUpdate is set to false so the SSLContextManager can stop to reload the same certificate when used in combination with the RotatingClientCertificateManager.

Please note that this feature is in preview.
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔐

@injectives injectives requested a review from bigmontz March 6, 2024 14:17
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔐

@injectives injectives merged commit 2db210a into neo4j:5.0 Mar 6, 2024
20 checks passed
@injectives injectives deleted the feature/mtls branch March 6, 2024 17:05
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants