Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt refactoring #1560

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Bolt refactoring #1560

merged 3 commits into from
Oct 25, 2024

Conversation

injectives
Copy link
Contributor

No description provided.

@injectives injectives force-pushed the feature/bolt-refactor branch 30 times, most recently from b1bb793 to 8bc069e Compare July 11, 2024 20:36
@injectives injectives force-pushed the feature/bolt-refactor branch 3 times, most recently from 95a2a2d to 6b072b8 Compare August 28, 2024 10:11
@injectives injectives force-pushed the feature/bolt-refactor branch from 0c72478 to 784230e Compare August 28, 2024 22:00
@injectives injectives force-pushed the feature/bolt-refactor branch 2 times, most recently from 72488b5 to a9ac556 Compare September 12, 2024 14:00
@injectives injectives force-pushed the feature/bolt-refactor branch 4 times, most recently from b65d6cb to a8f8e1e Compare September 19, 2024 16:34
@injectives injectives force-pushed the feature/bolt-refactor branch 12 times, most recently from 22c30bd to 8a5dfc4 Compare October 17, 2024 17:44
@injectives injectives force-pushed the feature/bolt-refactor branch from 8a5dfc4 to d674aaa Compare October 17, 2024 18:34
@injectives injectives changed the title draft Bolt refactoring Oct 17, 2024
Copy link
Contributor

@gjmwoods gjmwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just some minor stuff 💪

}

@SuppressWarnings({"DuplicatedCode", "ConstantValue"})
public void connect(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is a bit of a beast but not sure if it can broken down to make it more readable. Looks correct though.

null,
(ignored) -> {})
.thenCompose(boltConnection -> {
var supports = boltConnection.protocolVersion().compareTo(new BoltProtocolVersion(4, 0)) >= 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could use static versions

injectives and others added 2 commits October 25, 2024 10:10
…/PooledBoltConnectionProvider.java

Co-authored-by: Greg Woods <42248895+gjmwoods@users.noreply.github.com>
@injectives injectives merged commit 902c7ea into neo4j:5.0 Oct 25, 2024
19 of 20 checks passed
@injectives injectives deleted the feature/bolt-refactor branch October 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants