Make socket connection timeout configurable #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lower the default timeout to 5s and add the default value into javadoc |
Previously socket connect did not have a timeout and was bounded only by the timeout configured on the OS level. Such timeout could be rather long and result in repeated stalls trying to refresh routing table against a failed router.
It was previously set to 30 seconds which seems too long.
lutovich
force-pushed
the
1.1-config-socket-connect-timeout
branch
from
5fca890 to
f1a6685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously socket connect did not have a timeout and was bounded only by the timeout configured on the OS level. Such timeout could be rather long and result in repeated stalls trying to refresh routing table against a failed router.