Improve fatal error propagation in commit & rollback #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.5-tx-conn-error
branch
from
ec7db41
to
da01e2d
Compare
When establishing connection it was possible for `IOException` to get propagated directly to the user without being wrapped in a `ServiceUnavailableException`. This happened because `HandshakeHandler` only wrapped security-related exceptions with driver exceptions. It was problematic because rest of the codebase expects to deal with `ServiceUnavailableException`s. For example rediscovery and retries code can deal nicely with `ServiceUnavailableException`. This commit fixes the problem by making `HandshakeHandler` wrap all non-security related exceptions in `ServiceUnavailableException`.
lutovich
force-pushed
the
1.5-tx-conn-error
branch
from
da01e2d
to
7589646
Compare
Fatal errors terminate the transaction. It will fail to commit when terminated and rollback will be a no-op. All outstanding errors from previous queries should still be propagated. Previously transaction checked it's terminated status too early and sometimes did not propagate pending errors. This commit fixes the problem by moving the termination check to a place where all result cursors are fully fetched. So errors from cursors will always get propagated. Also added a constant for default `RoutingSettings` for convenience.
lutovich
force-pushed
the
1.5-tx-conn-error
branch
from
7589646
to
87a46c8
Compare
|
@lutovich waiting for the tests to go green before merging. |
Use direct drivers to fetch cluster overview from cores, instead of routing driver and write session. Wait for at most 60 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.