Simplified toString() for duration #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it normalized duration in order to expose a more human-friendly string. For example, 7 days would become a week, 12 months would become a year. It seems nice but might create a false impression that it is possible to retrieve weeks and years from an `IsoDuration` object. However, it only supports months, days, seconds and nanoseconds. Also, other drivers do not normalize durations. This commit makes `IsoDuration#toString()` simply concatenate all values into a string as is. Resulting string will only contain months, days, seconds and nanoseconds. Zero values are not filtered out. So returned ISO strings represent exactly same durations but in different format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it normalized duration in order to expose a more human-friendly string. For example, 7 days would become a week, 12 months would become a year. It seems nice but might create a false impression that it is possible to retrieve weeks and years from an
IsoDurationobject. However, it only supports months, days, seconds and nanoseconds. Also, other drivers do not normalize durations.This PR makes
IsoDuration#toString()simply concatenate all values into a string as is. Resulting string will only contain months, days, seconds and nanoseconds. Zero values are not filtered out. So returned ISO strings represent exactly same durations but in different format.