Improve handling of RESET and ACK_FAILURE errors #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.7-failure-on-reset-and-ack-failure
branch
from
3849411 to
f9efc0b
Compare
ali-ince
reviewed
May 29, 2018
| } | ||
|
|
||
| protected void resetCompleted( CompletableFuture<Void> completionFuture ) | ||
| protected void resetCompleted( CompletableFuture<Void> completionFuture, boolean success ) |
There was a problem hiding this comment.
Do we loose information without using the RESET outcome, i.e. success parameter?
There was a problem hiding this comment.
This response handler is used only for Session#reset() which is a best-effort call to clear the connection state on the database side. It might succeed, fail or do nothing regardless of a network error. That is why I thought it is okay to simply notify about the completion of the remote call here. Session#reset() is also deprecated :)
Does this make sense?
This commit makes driver close the network channel when either `RESET` or `ACK_FAILURE` receive an error response. Message `RESET` is sent before release of the channel back to the channel pool. It might fail if database experiences a fatal error (like `OutOfMemoryError`) or a network failure occurs. In case of such errors channel will be closed and returned to the pool, which will drop it later. Message `ACK_FAILURE` is sent to acknowledge a `FAILURE` response. Failure to do so is unrecoverable and should result in a connection being dropped.
lutovich
force-pushed
the
1.7-failure-on-reset-and-ack-failure
branch
from
f9efc0b to
ce57a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes driver close the network channel when either
RESETorACK_FAILUREreceive an error response. MessageRESETis sent before release of the channel back to the channel pool. It might fail if database experiences a fatal error (likeOutOfMemoryError) or a network failure occurs. In case of such errors channel will be closed and returned to the pool, which will drop it later. MessageACK_FAILUREis sent to acknowledge aFAILUREresponse. Failure to do so is unrecoverable and should result in a connection being dropped.