Adding tx with built-in retries support for RxSession #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
2.0-with-retries
branch
4 times, most recently
from
968dba7
to
dbce261
Compare
added 3 commits
April 10, 2019 10:26
…ssion and all tx are built on top of ExplictTx.
Added more IT for tx run with retries.
zhenlineo
force-pushed
the
2.0-with-retries
branch
from
3f75a13
to
ee20288
Compare
added 3 commits
April 10, 2019 12:02
By default, Project Reactor schedules delayed operations on a parallel scheduler, which is created lazily when needed. We can avoid creating such an extra resource by schedule the delayed work on our existing netty event loop thread pool. This behaviour is exactly the same as our existing async retries. Added tests to verify that the Parallel scheduler is not created.
… not used correctly.
zhenlineo
force-pushed
the
2.0-with-retries
branch
from
ee20288
to
a8b0306
Compare
ali-ince
reviewed
Apr 12, 2019
| import org.neo4j.driver.internal.cursor.RxStatementResultCursor; | ||
| import org.neo4j.driver.internal.spi.Connection; | ||
|
|
||
| public interface ExplicitTransaction |
There was a problem hiding this comment.
I slightly got confused with the new naming scheme. Since both NetworkSession and ExplicitTransaction are core building blocks for the rest of the surfaced API, what do you think about renaming ExplicitTransaction to NetworkTransaction - just to form a relationship between the two?
There was a problem hiding this comment.
The name NetworkTransaction dose not fits the Transaction very much. Will it be more clear if I remove the interfaces and directly call the implementations NetworkSession and ExplicitTransaction?
Then all sessions will be built on top of NetworkSession and all transactions are built on top of ExplicitTransaction.
There was a problem hiding this comment.
👍 I think that would help.
…ion`. And put implementation directly instead.
zhenlineo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
RxSession#readTransactionandRxSession#writeTransactionusingFlux#retryWhen.Extracted
NetworkSessionto provide basicrunAsyncandrunRxmethods, allowing other session implementations (such as AsyncSession, RxSession) build on top of it.