Make connectivity verification not part of driver creation. #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
reviewed
Jul 2, 2019
zhenlineo
force-pushed
the
2.0-verify-conn
branch
5 times, most recently
from
923d4b8
to
e5f6412
Compare
zhenlineo
force-pushed
the
2.0-verify-conn
branch
from
e5f6412
to
2f7e88c
Compare
zhenlineo
changed the title
ali-ince
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
LGTM @zhenlineo.
Maybe we can add an explicit warning note that even if the verifyConnectivity throws an exception, the user should still call Driver.close() to clean-up resources.
zhenlineo
force-pushed
the
2.0-verify-conn
branch
from
1b65b75
to
df314fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #587