System database bookmarks. #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple routing tables for the same database
zhenlineo
force-pushed
the
2.0-sys-bookmark
branch
3 times, most recently
from
32628dd
to
e328d6c
Compare
For bolt v4, when bookmark is passed into a session, if getRT call is invoked for that session, then the bookmark is passed down to the procedure call. Changed bookmark to be an object. The content of the object is transparent to driver users.
zhenlineo
force-pushed
the
2.0-sys-bookmark
branch
from
e328d6c
to
143cc47
Compare
ali-ince
reviewed
Aug 8, 2019
added 2 commits
August 9, 2019 14:46
…round without disclose the content of bookmark.
…rver configuration changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing system bookmarks to
getRTcall for bolt v4 connections. The main problem to solve is to find the routing table for a newly created database. When a new database is created, the system database is updated and then the new database is reconciled into existence asynchronously. The system database bookmarks allow us to make a causal link from the created database to the updated routing tables that included it.System Bookmarks are only used if a routing table update is needed when creating a session. If there is already a valid routing table, then the driver has no problem to route to the specified database in a cluster.
Bookmark is changed from a
StringtoBookmarkobject.Here is the story how this change happened.
Session#lastBookmarkneed to be able to return one or multiple bookmark strings. Normally, if we get a bookmark from server, the bookmark is a single string. However if the bookmark is provided by a user, then the bookmark can be a list of strings. AsSession#lastBookmarkcan be called any time, so the bookmark can be one or multiple bookmark strings. If we simply return aListof strings rather than aBookmarkobject, thenSessionConfig#withBookmarkshas to accept aListofListof string. This API dose not look good. Thus we come to the conclusion to make a bookmark object.In the driver implementation to support system bookmark, a
ConnectionContextis added to carry this system bookmarks down to rediscovery service. It is kind like aSessionConfigbut it carries current connection access mode rather than default access mode.