Better verify conn #657
Merged
Better verify conn #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2019 19:29
For a single driver, we will open a connection with the init server and then check if the server version is 4.0+ and talking with driver using bolt v4. For a routing driver, we will go through all addresses that are resolved from the init seed server. Then we will check with the first successfully connected server if the server version is 4.0+ and talking with driver using protocol bolt v4.
zhenlineo
force-pushed
the
4.0-better-verify-conn
branch
from
ec65910
to
922437f
Compare
zhenlineo
force-pushed
the
4.0-better-verify-conn
branch
from
922437f
to
b92919a
Compare
This ensures `getRT`, `verifyConnectivity`, and `supportsMultDb` all respect `SecurityException`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #654