Refactored BasicPullResponseHandler to use an explicit state machine #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjmwoods
force-pushed
the
4.0-refactor-pull-state-machine
branch
2 times, most recently
from
a40de29
to
73d7b84
Compare
zhenlineo
approved these changes
Dec 12, 2019
| @@ -267,13 +229,217 @@ private void dispose() | |||
| this.summaryConsumer = null; | |||
| } | |||
|
|
|||
| protected Status status() | |||
| protected State getState() | |||
There was a problem hiding this comment.
The driver uses naming style void status(Status s), and Status status(). This is because when we are tying to give a unified API across all languages, getXX and setXX does not apply in many languages such as python or Js. So we decided we use getter and setters in this driver without get and set. I would suggest to change the name back so that we keep the naming style in the whole codebase to be consistent.
| } | ||
|
|
||
| protected void status( Status status ) | ||
| protected void setState( State state ) |
gjmwoods
force-pushed
the
4.0-refactor-pull-state-machine
branch
from
73d7b84
to
6645f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
BasicPullResponseHandlerto make its state machine explicit.