Do not expect package com.oracle.svm at OSGi runtime #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current build process, some SVM substitutions got integrated to generate a native-image of the library. From an OSGi perspective, the integration of Oracles, respectively, Graal's substrate dependency causes an unintentional statement in the manifest.mf of the build result expecting a package called com.oracle.svm. This pull request adjusts the osgi.bnd file to avoid the com.oracle.svm package from being required when the bundle gets executed in an OSGi runtime. Expose also drivers internal package Libraries such as neo4j-ogm and its modules neo4j-ogm-bolt-driver and neo4j-ogm-bolt-native-types require access to the internal package of the neo4j java driver. To hide the internal package from the outside world classes used in neo4j-ogm such as InternalBookmark, Scheme has to be relocated to different package in further refactoring. For now, in OSGi work with neo4j-ogm and the bolt driver, especially the entire internal module, has to be exposed.
gurkerl83
force-pushed
the
Fix-Import-Package(OSGi)
branch
from
cf6fc37 to
ae5fa6c
Compare
|
Hi @gurkerl83 Thanks so much for your contribution. I didn't know about that bundle mechanism. Would you please be so kind and follow the instructions here to sign our CLA: https://neo4j.com/developer/cla/ and comment on the PR here? CI will build things afterwards. |
|
Hi, @michael-simons I signed the CLA, thx! |
|
I'm so sorry to pester you again because of that small and nice PR. You found a couple of issues in our whitelist check (by not having a name in your GH account (which is totally fine)) and by the fact that the commit to be merged is made with another account ( Is that you? If so, I add that account to the whitelist check as well. |
|
Hi, @michael-simons , both usernames (gurkerl83 and markus-gritsch) are me, thx! |
gjmwoods
pushed a commit
to gjmwoods/neo4j-java-driver
that referenced
this pull request
Jun 4, 2020
In the current build process, some SVM substitutions got integrated to generate a native-image of the library. From an OSGi perspective, the integration of Oracles, respectively, Graal's substrate dependency causes an unintentional statement in the manifest.mf of the build result expecting a package called com.oracle.svm. This pull request adjusts the osgi.bnd file to avoid the com.oracle.svm package from being required when the bundle gets executed in an OSGi runtime. Expose also drivers internal package Libraries such as neo4j-ogm and its modules neo4j-ogm-bolt-driver and neo4j-ogm-bolt-native-types require access to the internal package of the neo4j java driver. To hide the internal package from the outside world classes used in neo4j-ogm such as InternalBookmark, Scheme has to be relocated to different package in further refactoring. For now, in OSGi work with neo4j-ogm and the bolt driver, especially the entire internal module, has to be exposed. Co-authored-by: gurkerl83 <markus_gritsch@gmx.de>
gjmwoods
added a commit
that referenced
this pull request
Jun 8, 2020
In the current build process, some SVM substitutions got integrated to generate a native-image of the library. From an OSGi perspective, the integration of Oracles, respectively, Graal's substrate dependency causes an unintentional statement in the manifest.mf of the build result expecting a package called com.oracle.svm. This pull request adjusts the osgi.bnd file to avoid the com.oracle.svm package from being required when the bundle gets executed in an OSGi runtime. Expose also drivers internal package Libraries such as neo4j-ogm and its modules neo4j-ogm-bolt-driver and neo4j-ogm-bolt-native-types require access to the internal package of the neo4j java driver. To hide the internal package from the outside world classes used in neo4j-ogm such as InternalBookmark, Scheme has to be relocated to different package in further refactoring. For now, in OSGi work with neo4j-ogm and the bolt driver, especially the entire internal module, has to be exposed. Co-authored-by: gurkerl83 <markus_gritsch@gmx.de> Co-authored-by: gurkerl83 <gurkerl83@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current build process, some SVM substitutions got integrated to generate a native-image of the library. From an OSGi perspective, the integration of Oracles, respectively, Graal's substrate dependency causes an unintentional statement in the manifest.mf of the build result expecting a package called com.oracle.svm.
This pull request adjusts the osgi.bnd file to avoid the com.oracle.svm package from being required when the bundle gets executed in an OSGi runtime.