Skip to content

Upgrade Boltkit to 4.1. Adding BoltKit Test for NOOP message. #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2020
Merged

Upgrade Boltkit to 4.1. Adding BoltKit Test for NOOP message. #703

merged 3 commits into from
May 28, 2020

Conversation

gjmwoods
Copy link
Contributor

No description provided.

michael-simons
michael-simons requested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing and a couple of questions, otherwise lgtm.

driver/src/test/java/org/neo4j/driver/util/StubServer.java Outdated
}
catch ( InterruptedException ex )
{
Thread.currentThread().interrupt();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you interrupting the current thread in an interrupted block?

driver/src/test/java/org/neo4j/driver/util/StubServerController.java Outdated
}
catch ( InterruptedException e )
{
Thread.currentThread().interrupt();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sames as above…

driver/src/test/java/org/neo4j/driver/internal/DirectDriverBoltKitTest.java Outdated
{
StubServer server = StubServer.start( "noop.script", 9001 );
URI uri = URI.create( "bolt://127.0.0.1:9001" );
int x;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int x;

Unused.

@gjmwoods gjmwoods requested a review from michael-simons May 28, 2020 12:42
@gjmwoods gjmwoods merged commit be49698 into neo4j:4.1 May 28, 2020
@gjmwoods gjmwoods deleted the 4.1-noop branch May 28, 2020 13:03
gjmwoods added a commit to gjmwoods/neo4j-java-driver that referenced this pull request Jun 1, 2020
@gjmwoods
Upgrade Boltkit to 4.1. Adding BoltKit Test for NOOP message. (neo4j#703
7e34c94 
)
gjmwoods added a commit that referenced this pull request Jun 1, 2020
@gjmwoods
4.0 adapt for bolkit 4.1 (#722)
239d9de 
* Upgrade Boltkit to 4.1. Adding BoltKit Test for NOOP message. (#703)

* Adapt bolkit tests for boltkit 4.1 (#721)

Refactor `DirectDriverBoltKitTest` to ensure boltstub is restarted freshly for each run. Fix scripts that are broken with boltkit 4.1.

* Remove NOOP test, not needed for 4.0 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-simons michael-simons michael-simons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmwoods @michael-simons