Decouple TestkitState from CommandProcessor. #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
force-pushed
the
issue/decouple-testkitstate-and-processor
branch
from
2faa62c to
41df4bb
Compare
This commit remoces the command processor from the TestKit state. The processor is supposed to use that state, not to be part of it. However, some requests, like `NewDriver` need the processor to trigger further state. Therefor the processor is now provided as injectable value via Jackson, so that any request can indicate that it needs a processor via a constructor argument.
michael-simons
force-pushed
the
issue/decouple-testkitstate-and-processor
branch
from
41df4bb to
6f404b2
Compare
injectives
pushed a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Sep 6, 2021
This commit remoces the command processor from the TestKit state. The processor is supposed to use that state, not to be part of it. However, some requests, like `NewDriver` need the processor to trigger further state. Therefor the processor is now provided as injectable value via Jackson, so that any request can indicate that it needs a processor via a constructor argument.
injectives
added a commit
that referenced
this pull request
Sep 6, 2021
* Add support for Resolver and DomainNameResolver to async Testkit backend (#992) * Decouple TestkitState from CommandProcessor. (#993) This commit remoces the command processor from the TestKit state. The processor is supposed to use that state, not to be part of it. However, some requests, like `NewDriver` need the processor to trigger further state. Therefor the processor is now provided as injectable value via Jackson, so that any request can indicate that it needs a processor via a constructor argument. * Remove unnessary Lombok noise. (#995) * Migrate Testkit backend to Netty implementation (#994) * Migrate Testkit backend to Netty implementation * Remove unnessary Optional in processAsync. This brings both sync and asynchronous paths in TestKitState in symmetry. In addition, I noticed that the transaction related tests behaved differently in sync and async (when a tx is not found). I fixed that. * Remove redundant lines Co-authored-by: Michael Simons <michael.simons@neo4j.com> * Add reactive backend support (#998) This update brings reactive backend support. Its scope is limited to providing partial transparent support for existing test cases. More updates are expected in future PRs. Co-authored-by: Michael Simons <michael.simons@neo4j.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remoces the command processor from the TestKit state. The processor is supposed to use that state, not to be part of it.
However, some requests, like
NewDriverneed the processor to trigger further state.Therefor the processor is now provided as injectable value via Jackson, so that any request can indicate that it needs a processor via a constructor argument.