Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Benchkit Backend #1175

Merged
merged 15 commits into from
Feb 6, 2024
Merged

Introduce Benchkit Backend #1175

merged 15 commits into from
Feb 6, 2024

Conversation

bigmontz
Copy link
Contributor

This is a rest api for benchmarking driver in different for different workloads

@bigmontz bigmontz marked this pull request as ready for review January 30, 2024 14:00
thelonelyvulpes
thelonelyvulpes approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful.

robsdedude
robsdedude approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎💨

All just minor things.

benchkit/Dockerfile Show resolved Hide resolved
packages/benchkit-backend/package.json Outdated Show resolved Hide resolved
packages/benchkit-backend/resources/execute.requests.http Outdated Show resolved Hide resolved
packages/benchkit-backend/resources/create.requests.http Outdated Show resolved Hide resolved
packages/benchkit-backend/resources/create.requests.http Outdated Show resolved Hide resolved
packages/benchkit-backend/src/workload.store.js Outdated Show resolved Hide resolved
packages/benchkit-backend/src/workload.store.js Show resolved Hide resolved
packages/benchkit-backend/src/workload.validator.js Outdated Show resolved Hide resolved
packages/benchkit-backend/src/workload.validator.js Outdated Show resolved Hide resolved
packages/benchkit-backend/src/workload.executor.js Show resolved Hide resolved
bigmontz and others added 2 commits February 6, 2024 14:58
@bigmontz
Addressing comments in the PR
9ca1ca0
@bigmontz @robsdedude
Apply suggestions from code review
51a009a 
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
robsdedude
robsdedude approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶‍🌫️

@bigmontz bigmontz merged commit 9e01c71 into neo4j:5.0 Feb 6, 2024
37 checks passed
@bigmontz bigmontz deleted the 5.x-benchkit-backend branch February 6, 2024 16:25
@WontonSam WontonSam mentioned this pull request Jul 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@ThomasvanOtterloo ThomasvanOtterloo mentioned this pull request Jul 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 14, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 17, 2024
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 16, 2024
Open
Open
@jonkiky jonkiky mentioned this pull request Sep 20, 2024
Open
This was referenced Sep 21, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Oct 2, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 3, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelonelyvulpes thelonelyvulpes thelonelyvulpes approved these changes

@robsdedude robsdedude robsdedude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigmontz @robsdedude @thelonelyvulpes