Fix maxConnectionPoolSize verification
#1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under high load of sessions, the connection pool is allowing new connections to be created. This is happening because, while the development of `AuthTokenManager` and `connection liveness check`, the methods do validate connection on acquired and return to the pool need to be async. This changes creates a situation of racing condition which doesn't exist the original code and this introduces this bug. Increasing the resouce acquired count before validating the connection solves the issue, since the race condition is removed. However, the pool needs also to release the resource when the validation return `false` or fails for some reason. This is important to avoid broken connection still be count for the max pool size. Co-Authored-By: Max Gustafsson <max.gustafsson@neo4j.com>
bigmontz
force-pushed
the
fix-connection-pool-size
branch
from
2023922 to
bd2f597
Compare
The test were to tight and any slowness might cause the test to fail. Increase the time waiting for the connection get release to pool reduces the likehood of this problem happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under high load of sessions, the connection pool is allowing new connections to be created.
This is happening because, while the development of
AuthTokenManagerandconnection liveness check,the methods do validate connection on acquired and return to the pool need to be async.
This changes creates a situation of racing condition which doesn't exist the original code and this introduces this bug.
Increasing the resouce acquired count before validating the connection solves the issue, since the race condition is removed. However, the pool needs also to release the resource when the validation return
falseor fails for some reason.This is important to avoid broken connection still be count for the max pool size.