Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL errors and update to bolt protocol #1225

Merged
merged 35 commits into from
Oct 8, 2024
Merged

GQL errors and update to bolt protocol #1225

merged 35 commits into from
Oct 8, 2024

Conversation

MaxAake
Copy link
Contributor

@MaxAake MaxAake commented Sep 20, 2024

Implements GQL compliant properties on the Neo4jError object, which handles both error messages from the database and driver-side errors. Also polyfills these properties if an error is created without them. Old error messages and codes will still be available even for new GQL compliant errors to accommodate existing error handling.

@MaxAake
Copy link
Contributor Author

MaxAake commented Sep 20, 2024

@MaxAake MaxAake closed this Sep 20, 2024
Browser version of testkit was running firefox with a DNS cache, which was liable to cause failures of mixing up the cores, as they do not always keep their IP addresses
@MaxAake MaxAake reopened this Sep 20, 2024
@MaxAake MaxAake self-assigned this Sep 20, 2024
@MaxAake MaxAake marked this pull request as draft September 20, 2024 14:03
@MaxAake MaxAake changed the title GQL compliant error properties Update bolt protocol Sep 23, 2024
@MaxAake MaxAake marked this pull request as ready for review September 30, 2024 12:06
@MaxAake MaxAake changed the title Update bolt protocol GQL errors and update to bolt protocol Oct 1, 2024
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good in general, I have some questions and suggestions.

packages/bolt-connection/src/bolt/bolt-protocol-v5x6.js Outdated Show resolved Hide resolved
packages/bolt-connection/src/bolt/response-handler.js Outdated Show resolved Hide resolved
packages/core/src/error.ts Show resolved Hide resolved
packages/core/src/error.ts Outdated Show resolved Hide resolved
packages/core/src/error.ts Outdated Show resolved Hide resolved
testkit/testkit.json Outdated Show resolved Hide resolved
@MaxAake MaxAake requested a review from bigmontz October 4, 2024 12:02
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q.e.d.

@MaxAake MaxAake merged commit 3c63045 into 5.0 Oct 8, 2024
37 checks passed
@MaxAake MaxAake deleted the gql-errors branch October 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants