ADR 30 : New handshake for the bolt protocol #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timezones with minute offsets not divisible by 60 were causing issues for converting from the driver implementation of Date and Datetime to JS Date. A better implementation has been created and some documentation has been updated to reflect limitations that already existed.
This reverts commit 3104a29.
This reverts commit ff3dd5f.
|
|
||
| let major | ||
| let minor | ||
| versions.sort((a, b) => Number(b.major + '.' + b.minor) - Number(a.major + '.' + a.minor)) |
There was a problem hiding this comment.
It may not be an issue, but have you checked this covers trailing zeros in the conversation?
So Number(major + '.' + minor) converts versions into floats (5.7 becomes 5.7 but 4.10 might not behave as expected?)
There was a problem hiding this comment.
Good catch that I really should have realized myself! Thank you!
| versions.sort((a, b) => Number(b.major + '.' + b.minor) - Number(a.major + '.' + a.minor)) | ||
| for (let i = 0; i < versions.length; i++) { | ||
| const version = versions[i] | ||
| if (AVAILABLE_BOLT_PROTOCOLS.includes(Number(version.major + '.' + version.minor))) { |
There was a problem hiding this comment.
If no version matches, major and minor will be undefined, does this lead to any unexpected errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the handshake v2 protocol, allowing for more granular selection of bolt protocol versions.