Providing protocol version in Result get by Transaction.run #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result summary was not filled with the protocol version because the transactions were creating the Result object with a empty connection holder. Since the Result releases the connection from holder when it completes, the original holder could not be passed to it. The ReadOnlyConnectionHolder provides a safe way to pass the holder forward without let the consumer initialize, close or release the connection by simulating this methods without do the action and delegating part of the requests to the original ConnectionHolder. These changes also made shared-neo4j cluster friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result summary was not filled with the protocol version because the transactions were creating
the Result object with a empty connection holder. Since the Result releases the connection from holder
when it completes, the original holder could not be passed to it.
The ReadOnlyConnectionHolder provides a safe way to pass the holder forward without let the consumer initialize,
close or release the connection by simulating this methods without do the action and delegating part of the requests to the original ConnectionHolder.
These changes also made shared-neo4j cluster friendly.