Improve connection/protocol layers #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
4.3-improve-channel-connection
branch
2 times, most recently
from
a077aa4 to
d614d13
Compare
2hdddg
reviewed
Jan 4, 2021
bigmontz
force-pushed
the
4.3-improve-channel-connection
branch
from
48ed401 to
ae15f60
Compare
bigmontz
force-pushed
the
4.3-improve-channel-connection
branch
2 times, most recently
from
a646648 to
dccc3b4
Compare
The implementation of the connection channel, the protocol and handshake are dependent in the other in cross mutual dependency situation. This cross dependency situation could leave to unexpected behaviours when something change on this layers. The solution for this issue was separate the bolt protocol with it handshake process, creation, observers and so on in a different package to hide the details and make easier to spot the unwanted dependencies. The following changes were done to achieve these goals: * [x] Extract a factory for the connection removing the create method * [x] Extract the handshake process and separate in two, the handshake message exchange and the protocol initialisation * [x] Remove the response parsing and response observers management from the connection and put this in the bolt package (`response-handler.js`) * [x] Move the message write responsibility to the protocol object * [x] Remove connection dependency from the stream-observers * [x] Fix the connection integration tests * [x] Improve the unit tests * [x] Do not touch or break test kit tests and stress tests
bigmontz
force-pushed
the
4.3-improve-channel-connection
branch
from
dccc3b4 to
99d192d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the connection channel, the protocol and handshake are dependent in the other in cross mutual dependency situation. This cross dependency situation could leave to unexpected behaviours when something change on this layers.
The solution for this issue was separate the bolt protocol with it handshake process, creation, observers and so on in a different package to hide the details and make easier to spot the unwanted dependencies.
The following changes were done to achieve these goals:
response-handler.js)