Skip to content

[ADR-001] bookmark manager #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Aug 31, 2022
Merged

[ADR-001] bookmark manager #771

merged 32 commits into from
Aug 31, 2022

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Aug 3, 2022 •
edited
Loading

@robsdedude robsdedude changed the title [ADR-001] Initial draft of bookmark manager [ADR-001] bookmark manager Aug 3, 2022
robsdedude added 18 commits August 3, 2022 17:03
@robsdedude
Fix unit tests for config
1ecd68f
@robsdedude
TestKit backend support for bookmark manager
32273f9
@robsdedude
Fix bookmark manager
2279b67 
 * respect database reported in summary
 * fix lock usage
 * other small fixes
@robsdedude
Add support for ignore_bookmark_manager session config option
e696f07
@robsdedude
Lock bookmark manager per db
693b9b5
@robsdedude
Add forget method to bookmark manager
4ec20b3
@robsdedude
Add API docs for the bookmark manager
ad092c9
@robsdedude
Implement bookmark_consumer and remove must_included_databases
e804076 
Implement ADR adjustments to bookmark manager
neo-technology/drivers-adr#30
@robsdedude
Make Bookmarks not iterable
bb0efae
@robsdedude
Merge branch '5.0' into bookmark-manager
206bfbe
@robsdedude
TestKit backend support for BMM extension functions
ecd70db
@robsdedude
Fix corner-case usages of the BMM within Session
90d6abc
@robsdedude
Unit tests for BMM
bb07e19
@robsdedude
Fix TestKit backend handling of BMM config options
4712348
@robsdedude
Rename bookmark manager hooks
8902770 
`bookmark_consumer` -> `bookmarks_consumer`
`bookmark_supplier` -> `bookmarks_supplier`

neo-technology/drivers-adr#31
@robsdedude
TestKit add Optimization:MinimalBookmarksSet flag
87f4eaf
@robsdedude
Add performance warning for when enabling the BMM
1e0d440
@robsdedude
Merge branch '5.0' into bookmark-manager
bd5e6a9
@robsdedude robsdedude marked this pull request as ready for review August 19, 2022 09:19
fbiville
fbiville reviewed Aug 19, 2022
View reviewed changes
bigmontz
bigmontz requested changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes on the workspace might broke session.last_bookmarks() current behaviour.

fbiville and others added 3 commits August 22, 2022 13:54
@fbiville @robsdedude
It's manager... not manger, duh!
97189f0 
Signed-off-by: Rouven Bauer <rouven.bauer@neo4j.com>
@robsdedude
Revert unrelated change to tests
44eef98 
The change was meant to get rid of a deprecation warning.
It'll be moved into it's own PR.
@fbiville @robsdedude
Clean-up
c166e2b 
 * Avoid calling the BMM implementation that's shipped with the driver "default
   bookmark manger". This could lead users to believe it's enabled by default.
 * little oversights

Signed-off-by: Rouven Bauer <rouven.bauer@neo4j.com>
robsdedude
robsdedude commented Aug 22, 2022
View reviewed changes
bigmontz and others added 2 commits August 22, 2022 15:10
@bigmontz @robsdedude
Clean-up
3891c4e 
 * Adjust BMM interface: bookmark types are now `Collection`s instead of
   `Iterable`s. This allows for slightly more efficient BMM implementations
   without creating significant friction in the usage of BMMs.
 * Docs typo.

Signed-off-by: Rouven Bauer <rouven.bauer@neo4j.com>
@robsdedude
Fix session.last_bookmarks() leaking bookmarks from BMM
517c07d 
Discovered by Antonio
@robsdedude robsdedude requested a review from bigmontz August 29, 2022 14:05
fbiville
fbiville approved these changes Aug 30, 2022
View reviewed changes
robsdedude and others added 3 commits August 30, 2022 11:00
@robsdedude @fbiville
Fix spelling
af13113 
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
@robsdedude
Merge branch '5.0' into bookmark-manager
fe7a7bd
@robsdedude
Merge branch '5.0' into bookmark-manager
17bdfda
bigmontz
bigmontz approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔖 🧑‍💼

@robsdedude
Copy link
Member Author

Waiting for neo4j-drivers/testkit#509 to be merged. Then re-run CI.

@robsdedude robsdedude merged commit 212cfd4 into neo4j:5.0 Aug 31, 2022
@robsdedude robsdedude deleted the bookmark-manager branch August 31, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbiville fbiville fbiville approved these changes

@bigmontz bigmontz bigmontz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robsdedude @fbiville @bigmontz