Convert non-json-serializable properties to strings #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnsch
force-pushed
the
allow-non-json-serializable
branch
from
172fa11 to
7b58b9d
Compare
FlorentinD
approved these changes
May 22, 2025
Collaborator
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
Fix looks good to me.
Just have 2 suggestions. One around the json.dump calls and second around testing
adamnsch
force-pushed
the
allow-non-json-serializable
branch
from
7b58b9d to
99fbbe4
Compare
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Co-Authored-By: Florentin Dörre <florentin.dorre@neotechnology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Graph Visualization for Python project by Neo4j.
Before submitting this PR, please read Contributing to the Neo4j Ecosystem.
Make sure: