Fix bug in heterogenous gds #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the from_gds function where graphs with heterogeneous relationship types having different properties would fail. The fix changes the relationship data fetching logic to handle multiple relationship types separately and updates the data structure to use a list of DataFrames instead of a single DataFrame.
- Modified relationship fetching to process each relationship type individually
- Updated function signature from
_fetch_rel_dfto_fetch_rel_dfsreturning a list of DataFrames - Updated test cases to reflect the new heterogeneous relationship handling
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python-wrapper/src/neo4j_viz/gds.py | Refactored relationship fetching to handle multiple relationship types with different properties |
| python-wrapper/tests/test_gds.py | Updated test data structures and assertions to match the new heterogeneous relationship handling |
| changelog.md | Added entry documenting the bug fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.