-
Notifications
You must be signed in to change notification settings - Fork 274
Fix / upd: properties declared on parent after inheritance takes place are now passed to children #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / upd: properties declared on parent after inheritance takes place are now passed to children #1428
Conversation
|
This PR has a minor conflict with #1419 |
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
+ Coverage 96.81% 96.81% +<.01%
==========================================
Files 205 205
Lines 12511 12539 +28
==========================================
+ Hits 12112 12140 +28
Misses 399 399
Continue to review full report at Codecov.
|
|
I suppose this update has the capacity to break things... If it is something you're interested in accepting, might be a good idea to release it along with #1419 |
|
Thanks so much for this! I would say this falls into the bugfix camp, but I'll release it in 9.0.0 just to make sure. I resolved the conflict and now waiting for Travis to finish before merging (though I might not get back to it this evening) |
|
awesome |
|
9.0.0 released |
|
Whoo hoo |
I'm not sure if this is a bug or intended behavior, but currently: if an ActiveNode class
Ais inherited byB, and then an ActiveNodepropertyis subsequently declared onA,Bwill not have that property (i.e. properties are only be transferred at inheritance).This PR makes it so that every property declared on a parent is also present on the children (unless
undef_propertywas explicitly called on a child).In achieving this, I plucked
ActiveSupport/core_ext/class/subclassesand added thesubclassesmethod toClass.This pull introduces/changes:
subclassesmethodExample
Pings:
@cheerfulstoic
@subvertallchris