Skip to content

Commit

Permalink
node: Drop node 16 support due to commitlint
Browse files Browse the repository at this point in the history
  • Loading branch information
BenjD90 committed Oct 30, 2023
1 parent 6be9e0f commit 84226e9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
},
"homepage": "https://github.com/neo9/n9-mongodb-client#readme",
"engines": {
"node": ">= 16.20"
"node": ">= 18"
},
"dependencies": {
"@neo9/n9-node-log": "^5.0.0-rc.7",
Expand Down
6 changes: 3 additions & 3 deletions test/locks.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ test('[LOCKS] Try ensuring index with wrong collection name', async (t: Executio
result = await lock.ensureIndexes();
},
{
message: "Collection names must not contain '$'",
message: 'Invalid collection name: $collection-name',
},
);
t.truthy(!result, "The lock can't be ensured due to invalid collection name (contains $)");
Expand All @@ -534,7 +534,7 @@ test('[LOCKS] Try acquiring lock with wrong collection name', async (t: Executio
code = await lock.acquire();
},
{
message: "Collection names must not contain '$'",
message: 'Invalid collection name: $collection-name',
},
);
t.truthy(!code, "The lock can't be acquired due to invalid collection name (contains $)");
Expand Down Expand Up @@ -569,7 +569,7 @@ test('[LOCKS] Try releasing lock with wrong collection name', async (t: Executio
ok = await lock.release('a-fake-lock-id');
},
{
message: "Collection names must not contain '$'",
message: 'Invalid collection name: $collection-name',
},
);
t.truthy(!ok, "The lock can't be released due to invalid collection name (contains $)");
Expand Down

0 comments on commit 84226e9

Please sign in to comment.