Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(esbuild): upgrade esbuild to 0.17 #4486

Closed
wants to merge 1 commit into from
Closed

fix(esbuild): upgrade esbuild to 0.17 #4486

wants to merge 1 commit into from

Conversation

fannheyward
Copy link
Member

esbuild removed watch option, needs to use context.watch() instead https://github.com/evanw/esbuild/releases/tag/v0.17.0

remove watch mode for now

@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Base: 98.76% // Head: 98.76% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (54c2edb) compared to base (bf83393).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4486      +/-   ##
==========================================
- Coverage   98.76%   98.76%   -0.01%     
==========================================
  Files         273      273              
  Lines       25918    25913       -5     
  Branches     5375     5374       -1     
==========================================
- Hits        25599    25593       -6     
- Misses        184      185       +1     
  Partials      135      135
Impacted Files Coverage Δ
src/core/notifications.ts 98.41% <100.00%> (ø)
src/model/notification.ts 97.72% <100.00%> (-2.28%) ⬇️
src/model/progress.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fannheyward
fix(esbuild): upgrade esbuild to 0.17
54c2edb 
esbuild removed `watch` option, needs to use `context.watch()` instead https://github.com/evanw/esbuild/releases/tag/v0.17.0

remove watch mode for now
fannheyward added a commit that referenced this pull request May 4, 2023
@fannheyward
chore(yarn): upgrade dev-dependencies
587b10a 
- TS
- eslint
- esbuild

closes #4615 #4486
@fannheyward fannheyward mentioned this pull request May 4, 2023
Merged
@fannheyward fannheyward closed this May 4, 2023
fannheyward added a commit that referenced this pull request May 4, 2023
@fannheyward
chore(yarn): upgrade dev-dependencies
e4ee323 
- TS@5
- esbuild 0.17, remove watch mode
- eslint, jsdoc/newline-after-description to jsdoc/tag-lines, use the recommended 1

closes #4615 #4486
fannheyward added a commit that referenced this pull request May 4, 2023
@fannheyward
chore(yarn): upgrade dev-dependencies
5557f77 
- TS@5
- esbuild 0.17, remove watch mode
- eslint, jsdoc/newline-after-description to jsdoc/tag-lines, use the recommended 1

closes #4615 #4486
oblitum pushed a commit that referenced this pull request May 29, 2023
@fannheyward
chore(yarn): upgrade dev-dependencies (#4627)
19c782e 
- TS@5
- esbuild 0.17, remove watch mode
- eslint, jsdoc/newline-after-description to jsdoc/tag-lines, use the recommended 1

closes #4615 #4486
@fannheyward fannheyward deleted the fix/esbuild-17 branch June 28, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fannheyward