-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI option "quality" for the "convert-svg-to-jpeg" does not work #65
Comments
Agreed, found the same bug when running tests, needs a PR |
* **Breaking Change:** All packages now require Node.js version 12.20.0 or newer * Support UTF-8 characters in SVG * Support SVG dimensions (width, height) that use `pt` units * Add `rounding` API and CLI option to control how dimensions are rounded (defaults to `"round"`) * Fix [CVE-2021-23631](https://nvd.nist.gov/vuln/detail/CVE-2021-23631) by improving input validation * `quality` CLI option for JPEG not passed correctly [#65](#65) * Bump dependencies (incl. major for Puppeteer) * Bump devDependencies * Skip inconsistent tests
I'm sorry for the incredibly long delay in replying in responding to you but life sometimes gets in the way of OSS development. I thank you for your patience and, although I'm closing this issue out, I hope you'll be glad to know that I believe this issue has been resolved in with today's 0.6.0 release. If you continue to have this problem, please raise a new ticket with an SVG to reproduce the problem and, where possible, an expected and actual file of the output. I hope you can understand my delay. |
The package
convert-svg-to-jpeg
has incorrect CLI settings for thequality
argument option.Error example:
It seems that method
getCLIOptions
of theJPEGProvider
class doesn't return correct values.I think that instead of
it should be
The text was updated successfully, but these errors were encountered: