Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js compatibility #5

Closed
neocotic opened this issue Dec 4, 2012 · 2 comments
Closed

Node.js compatibility #5

neocotic opened this issue Dec 4, 2012 · 2 comments
Assignees
@neocotic
Labels
feature request
Milestone
2.0.0

Comments

@neocotic
Copy link
Owner

neocotic commented Dec 4, 2012

Look at using jsdom.
@ghost ghost assigned neocotic Dec 4, 2012
neocotic added a commit that referenced this issue Dec 6, 2012
@neocotic
#5 now supports node.js #4 fixed some issues with CoffeeScript rewrite
864b278
@neocotic neocotic mentioned this issue Dec 7, 2012
Closed
@neocotic
Copy link
Owner Author

neocotic commented Dec 7, 2012

jsdom was a perfect match! The library appears to work great in node.js but needs to be retested in the browser (separately to the standard unit tests - #3) to ensure the code works great in both environments. Also, I want to test the library works well when using the CommonJS AMD pattern.

Once this has been tested I'll be happy to close of this issue.

@neocotic
Copy link
Owner Author

neocotic commented Dec 7, 2012

Works fine in browser, even when using CommonJS. I'll close this off now as this doesn't require full functionality testing, just compatibility testing.

@neocotic neocotic closed this as completed Dec 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neocotic neocotic

Labels
feature request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@neocotic