(#35) Fix errors in IE 8 and older #36
Conversation
Without this patch, IE 8 raises the error "Object doesn't support this property or method" and fails to parse. One error was caused by match() being called on a CSSStyleDeclaration object instead of a String. Another error was caused by window.Node being undefined in IE 8 and older. This patch checks for match() to be a function before calling it. This patch also defines window.Node if it needs to be defined.
|
I did have a workaround pre-3.0 that handled the latter case but I don't know why I removed it to be honest. I'm going to have a think and try to remember why I removed this though it was probably an oversight. Thanks for your contributions and sorry for taking so long to get back to you. |
| @@ -149,6 +149,22 @@ class HtmlParser | |||
| url: @options.base | |||
| @win = doc.createWindow() | |||
|
|
|||
| # Create the Node constants if Node doesn't exist (i.e. when running in IE < 9). | |||
| unless @win.Node? | |||
| @win.Node = | |||
There was a problem hiding this comment.
Since we only really reference ELEMENT_NODE and TEXT_NODE elsewhere in the code, it would be better to get rid of the others.
|
Apologies, closed by accident. I remember why I removed the existing polyfiller for Once you've made the previously recommended changes I'll be happy to merge this in. |
Only ELEMENT_NODE and TEXT_NODE are used in this project so the other Node constants can be removed. Certainly cleans up the code.
|
No problem. Thanks for reviewing this! |
(#35) Fix errors in IE 8 and older
This pull request addresses issue #35.
Without this patch, IE 8 raises the error "Object doesn't support this property or method" and fails to parse. One error was caused by
match()being called on aCSSStyleDeclarationobject instead of aString. Another error was caused bywindow.Nodebeing undefined in IE 8 and older. This patch checks formatch()to be a function before calling it. This patch also defineswindow.Nodeif it needs to be defined.